Session cost add message #1007
Open
Session cost add message #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
Pietfried
requested changes
Mar 7, 2025
lib/ocpp/v16/charge_point_impl.cpp
Outdated
Comment on lines
3176
to
3168
| if (!messages.empty()) { | ||
| session_cost_message.message = messages; | ||
| } |
There was a problem hiding this comment.
And you can drop this
Suggested change
| if (!messages.empty()) { | |
| session_cost_message.message = messages; | |
| } |
There was a problem hiding this comment.
why?
then the messages are not included?
There was a problem hiding this comment.
You should now be able to drop
#include <ocpp/v2/functional_blocks/display_message.hpp>
There was a problem hiding this comment.
It does not build in that case: it is missing message_content_to_display_message_content then
…cing information. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
force-pushed
the
feature/session-cost-add-message
branch
from
343ea0a to
07368e3
Compare
Pietfried
requested changes
Mar 11, 2025
|
|
||
| ## OCPP 2.0.1 | ||
|
|
||
| OCPP 2.0.1 uses different mechanisms to send pricing information. The messages are converted to internally used structs as descripbed above. For California Pricing Requirements to work, DisplayMessage and TariffAndCost must be implemented as well. | ||
| OCPP 2.0.1 uses different mechanisms to send pricing information. The messages are converted to internally used structs as descripbed above. For California Pricing Requirements to work, TariffAndCost must be implemented as well. |
There was a problem hiding this comment.
Suggested change
| OCPP 2.0.1 uses different mechanisms to send pricing information. The messages are converted to internally used structs as descripbed above. For California Pricing Requirements to work, TariffAndCost must be implemented as well. | |
| OCPP 2.0.1 uses different mechanisms to send pricing information. The messages are converted to internally used structs as described above. For California Pricing Requirements to work, TariffAndCost must be implemented as well. |
|
|
||
| For the tariff information (the personal messages), the `set_display_message_callback` is used. The same callback is also used for the SetDisplayMessageRequest in OCPP. The latter does require an id, the former will not have an id. So when `GetDisplayMessageRequest` is called from the CSMS, the Tariff display messages (that do not have an id) should not be returned. They should also be removed as soon as the transaction has ended. | ||
| For the tariff information (the personal messages), the `session_cost_message_callback` is used. |
There was a problem hiding this comment.
Suggested change
| For the tariff information (the personal messages), the `session_cost_message_callback` is used. | |
| For the tariff information (the personal messages), the `session_cost_message_callback` is used. |
| @@ -161,6 +161,9 @@ struct Callbacks { | |||
| std::optional<std::string> currency_code)>> | |||
| set_running_cost_callback; | |||
|
|
|||
| /// \brief Callback function is called when tariff message is set. | |||
There was a problem hiding this comment.
Suggested change
| /// \brief Callback function is called when tariff message is set. | |
| /// \brief Callback function is called when a tariff message from the CSMS message has been received. |
There was a problem hiding this comment.
I think it would help to give a little bit more context here and to describe whats expected from the callback.
include/ocpp/v16/charge_point.hpp
Outdated
| @@ -573,6 +573,12 @@ class ChargePoint { | |||
| const std::function<DataTransferResponse(const RunningCost& session_cost, const uint32_t number_of_decimals)>& | |||
| session_cost_callback); | |||
|
|
|||
| /// \brief Registers a callback function for the session cost text message (California Pricing Requirements). | |||
There was a problem hiding this comment.
I think it would help to give a little bit more context here and to describe whats expected from the callback.
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Do not use the display message interface to send session cost messages, but use a specific session cost message type.
Issue ticket number and link
Checklist before requesting a review